Implement getDirSize in pure PHP #9907
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids starting an external program, and make the code more compatible. For instnace, BSD du comand does not have a -b option. But the function should probably be moved in another file, objects/functionsExec.php being dedicated to running external programs.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Hello
This change was not reviewed, it is an improvement without apparent drawback.
What about merging it?
…--
Emmanuel Dreyfus
***@***.***
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids starting an external program, and make the code more compatible. For instnace, BSD du comand does not have a -b option.
But the function should probably be moved in another file, objects/functionsExec.php being dedicated to running external programs.