Avoid uniqid() for performance sake #9905
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uniqid() provides time-based unique idenfitiers. In order to avoid collisions, it waits for time to elapse. Depending on PHP version, this is done by sleeping or by polling the gettimeofday() system call, both approach being rather inefficient. uniqid() may take a few dozen of milliseconds to return, and it is called very often to build a page. AVideo implements _uniqid() which provides random-based unique identifiers. This change replace uniqid() calls by _uniqid() to improve performances.
|
Sorry but I do not like this find and replace without test also I am not sure if it will make any difference in the performance. Currently you are the only one complaining that slow down on last update also does it already makes any difference for you? how much performance did you gain? |
|
On Thu, Feb 27, 2025 at 07:19:12PM -0800, Daniel Neto wrote:
Sorry but I do not like this find and replace without test
I agree the change is intrusive. What about adding a global
option to decide what implementation to use?
Currently you are the only one complaining that slow down on last update
I updated from 8.9.1
also does it already makes any difference for you? how much performance did you gain?
Before the change, the home page takes 16s to load.
After the change, it loads in 0.7s.
|
(that means: PHP native uniqid() is used unless the setting is toggled) _uniqid() also gets an optional parameter to force the local implementation instead of native PHP uniqid(), whatever the global setting is.
as we may have been included from a plugin.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Hi,
This is an update to keep the issue open. There was not comment on the
latest patch, was there?
…--
Emmanuel Dreyfus
***@***.***
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uniqid() provides time-based unique idenfitiers. In order to avoid collisions, it waits for time to elapse. Depending on PHP version, this is done by sleeping or by polling the gettimeofday() system call, both approach being rather inefficient. uniqid() may take a few dozen of milliseconds to return, and it is called very often to build a page.
AVideo implements _uniqid() which provides random-based unique identifiers. This change replace uniqid() calls by _uniqid() to improve performances.