Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notification)!: add more NotificationBuilder parameters #70

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

WSH032
Copy link
Owner

@WSH032 WSH032 commented Feb 5, 2025

Summary

Added:

parameters

  • id
  • channel_id
  • large_body
  • summary
  • action_type_id
  • group
  • group_summary
  • sound
  • inbox_line
  • icon
  • large_icon
  • icon_color
  • ongoing
  • auto_cancel
  • silent

BREAKING CHANGE: Removed NotificationBuilderArgs

Previously:

from pytauri_plugin_notification import NotificationBuilderArgs

notification_builder.show(
    NotificationBuilderArgs(title="Greeting", body=f"Hello, {body.name}!")
)

Now:

notification_builder.show(title="Greeting", body=f"Hello, {body.name}!")

Checklist

  • I've read CONTRIBUTING.md.
  • I understand that this PR may be closed in case there was no previous discussion/issue. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation and/or CHANGELOG.md accordingly.

Added:

parameters
- `id`
- `channel_id`
- `large_body`
- `summary`
- `action_type_id`
- `group`
- `group_summary`
- `sound`
- `inbox_line`
- `icon`
- `large_icon`
- `icon_color`
- `ongoing`
- `auto_cancel`
- `silent`

BREAKING CHANGE: Removed `NotificationBuilderArgs`
@WSH032 WSH032 changed the title feat(notification)!: add more NotificationBuilder arguments feat(notification)!: add more NotificationBuilder parameters Feb 5, 2025
@WSH032 WSH032 force-pushed the feat/notification branch from c707556 to 0df32eb Compare February 5, 2025 14:37
@WSH032 WSH032 merged commit d29a420 into main Feb 5, 2025
12 checks passed
@WSH032 WSH032 deleted the feat/notification branch February 5, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant