Highlight code blocks, fix emphasis #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marked as non substantive for IPR from ash-nazg. |
rniwa
requested changes
Nov 21, 2017
proposals/Template-Instantiation.md
Outdated
| @@ -397,7 +408,7 @@ The `createInstance(optional any state)` method on `HTMLTemplateElement`, when | |||
| 4. Let *parts* be an empty list. | |||
| 5. For every [descendent](https://dom.spec.whatwg.org/#concept-tree-descendant) node *currentNode* of *instance* in [tree order](https://dom.spec.whatwg.org/#concept-tree-order), run these steps: | |||
| 1. If *currentNode* is a [template element](https://html.spec.whatwg.org/multipage/scripting.html#the-template-element): | |||
| 1. Run the concept to _adjust single node case_ with *currentNode***.** | |||
| 1. Run the concept to _adjust single node case_ with *currentNode.* | |||
proposals/Template-Instantiation.md
Outdated
| <section><h1>Ryosuke Niwa</h1>Email: <a href="mailto:[email protected]”>[email protected]</a></section> | ||
| ``` html | ||
| <section> | ||
| <h1>Ryosuke Niwa</h1> |
There was a problem hiding this comment.
Please don't reformat examples like this. Whitespaces after h1 Before "Email:" would not be collapsed so it would affect the final DOM tree.
proposals/Template-Instantiation.md
Outdated
| <section><h1>Ryosuke Niwa</h1>Email: <a href="mailto:[email protected]”>[email protected]</a></section> | ||
| ``` html | ||
| <section> | ||
| <h1>Ryosuke Niwa</h1> |
proposals/Template-Instantiation.md
Outdated
| <template id="foo"><div class="foo {{ f(y) }}">{{ x }} world</div></template> | ||
| ``` html | ||
| <template id="foo"> | ||
| <div class="foo {{ f(y) }}">{{ x }} world</div> |
rniwa
reviewed
Nov 21, 2017
proposals/Template-Instantiation.md
Outdated
| <template type="my-template-type" id="contactTemplate"> | ||
| <section><h1>{{name}}</h1>Email: <a href="mailto:{{email}}">{{email}}</a></section> | ||
| <section> | ||
| <h1>{{name}}</h1> |
There was a problem hiding this comment.
Please undo this reformatting.
|
Thanks for the fixes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.