Skip to content
This repository was archived by the owner on Feb 26, 2025. It is now read-only.

Allow slashes in built-in module specifiers #164

Merged
merged 2 commits into from
Jul 30, 2019
Merged

Allow slashes in built-in module specifiers #164

merged 2 commits into from
Jul 30, 2019

Conversation

domenic
Copy link
Collaborator

@domenic domenic commented Jul 22, 2019 •
edited by pr-preview bot
Loading

Closes #129.

Preview | Diff

@domenic domenic force-pushed the domenic/allow-slashes-in-std branch from 9535baf to 1c6e1c8 Compare July 22, 2019 15:19
@domenic domenic mentioned this pull request Jul 22, 2019
Closed
guybedford
guybedford approved these changes Jul 22, 2019
View reviewed changes
Copy link
Collaborator

@guybedford guybedford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. It would still be nice to implement the multiple fallback handling instead of explicitly handling lengths 0, 1 and 2 as it would remove the specific code / spec tied to the cases.

@hiroshige-g
Copy link
Collaborator

Step 1.1 of validate a module script URL should be also removed.
As for other parts LGTM.

@domenic
Copy link
Collaborator Author

domenic commented Jul 30, 2019

Good catch, thank you @hiroshige-g!

@domenic domenic merged commit d5add26 into master Jul 30, 2019
@domenic domenic deleted the domenic/allow-slashes-in-std branch July 30, 2019 19:55
This was referenced Oct 6, 2019
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@guybedford guybedford guybedford approved these changes

@hiroshige-g hiroshige-g Awaiting requested review from hiroshige-g

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reference implementation/spec: allow std:x/y built-in modules
3 participants
@domenic @hiroshige-g @guybedford