Add noplaybackrate supported token to controlsList
#13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marcoscaceres Please have a look at this PR. |
|
Seems reasonable. Thanks for the ping! |
This was referenced May 21, 2021
neptunesoft
pushed a commit
to neptunesoft/chromium
that referenced
this pull request
Jun 4, 2021
This CL adds a new "noplaybackrate" token to the HTMLMediaElement controlsList attribute to let developers enable/disable playback speed control in native media controls. Intent to prototype and ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/u9jsiarDEOg Spec: WICG/controls-list#13 Bug: 1211336 Change-Id: I11240652b5000972398d2f5faa8267035aa9abb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2905660 Reviewed-by: Yoav Weiss <[email protected]> Reviewed-by: Tommy Steimel <[email protected]> Reviewed-by: Frank Liberato <[email protected]> Commit-Queue: François Beaufort <[email protected]> Cr-Commit-Position: refs/heads/master@{#889324}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As browser vendors are about to add playback speed controls to their native media player, it would be good if web developers could control the visibility of this new control.
Following HTMLMediaElement.playbackRate naming, this PR adds a new
noplaybackratesupported token toHTMLMediaElement.controlsList.Safari Technology Preview Release 123 screenshot
Chrome Canary 92.0.4512.4 screenshot