Change "attributeon" naming to "attributiondestination" #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csharrison
approved these changes
Mar 23, 2021
johnivdel
added a commit
that referenced
this pull request
Apr 30, 2021
* Update spec to current explainer This updates the draft spec to include all changes which were landed to the explainer since it was last updated. This includes: - all naming changes on #103 and #121 - removal of hexadecimal encoding for data fields Algorithm definitions and variables are updated to reflect the new naming. * Update index.bs * Update index.bs * Update index.bs * Update index.bs * Update index.bs * Respond to review feedback * Apply suggestions from code review Co-authored-by: Jeffrey Yasskin <[email protected]> * Apply suggestions from code review Co-authored-by: Jeffrey Yasskin <[email protected]> * Update index.bs * Update index.bs Co-authored-by: Jeffrey Yasskin <[email protected]>
johnivdel
added a commit
that referenced
this pull request
Apr 30, 2021
This was changed in the top level readme on #121 and should remain consistent across all API environments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the explainer with new naming as discussed on privacycg/private-click-measurement#75 (comment)