Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new build and deployment process #380

Merged
merged 40 commits into from
Apr 2, 2024
Merged

new build and deployment process #380

merged 40 commits into from
Apr 2, 2024

Conversation

joefutrelle
Copy link
Contributor

@joefutrelle joefutrelle commented Aug 30, 2023

  • fixed image build
  • use of Docker Hub images, eliminating need for deployer to do a docker build
  • attempt to configure everything with .env requiring few if any changes to docker-compose file

@joefutrelle joefutrelle self-assigned this Aug 30, 2023
@joefutrelle
Copy link
Contributor Author

TODO: pin dependencies and remove :latest from postgis and other images where new releases might break existing functionality.

@joefutrelle
Copy link
Contributor Author

Agreed on all points, I would love a PR against new_build with all the changes you suggested but I'm happy to implement it myself if you don't have time.

* Attempt import of local_settings in settings.py
* Remove local_settings.py from scm since its duplicated in settings.py
* Allow config of postgres password from POSTGRES_PASSWORD env var
* Use /dev/null for local_settings.py volume mount by default
@srstsavage
Copy link
Contributor

Implemented all suggested changes in #382, let me know if anything needs to be changed!

@joefutrelle
Copy link
Contributor Author

Great that you've also reduced the size of the image @srstsavage, any other things you want to do before I review #382?

@srstsavage
Copy link
Contributor

@joefutrelle Nope, all ready for review!

@joefutrelle joefutrelle marked this pull request as ready for review March 22, 2024 12:21
@joefutrelle
Copy link
Contributor Author

Note that when we merge this we should not delete the new_build branch until I notify the IFCB Users Group since I currently am instructing alpha testers to use it.

@joefutrelle joefutrelle requested a review from mike-kaimika April 1, 2024 18:58
@joefutrelle
Copy link
Contributor Author

@srstsavage I pinned all the dependencies and created a corresponding release tag for pyifcb and so I think this is buttoned up. Can you give this a spin?

Copy link
Collaborator

@mike-kaimika mike-kaimika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current state of the new_build branch is working for me.

For the related pyifcb library, what branch should I/we be using to test? I'm still on version_lock_scipy, but that may be old and out of date

Nevermind; user error. I just saw your comment about the branch being named the same in that library as well. I ran the app locally using that branch and had no issues

@srstsavage
Copy link
Contributor

@joefutrelle Seems to be working well!

@joefutrelle
Copy link
Contributor Author

There's the matter of #383 which is pending against this branch, and I want to get that in before the release. @mike-kaimika do you want to retarget #383 against master after doing this merge, or do you think it's better to get those changes into new_build before we merge this PR?

@mike-kaimika
Copy link
Collaborator

I think it probably makes more sense to get it merged into this branch, assuming neither of you had any issues with it. That way there's just one final branch for all the revisions.

@joefutrelle joefutrelle merged commit 11f4e75 into master Apr 2, 2024
@joefutrelle
Copy link
Contributor Author

  • Not deleting this branch
  • Next steps are cutting a release and pushing a freshly-built multiplatform image to Docker Hub.

@srstsavage
Copy link
Contributor

Deployment using the updated whoi/ifcb-dashboard Docker Hub image (sha256:4f13deefec11da3076ba48d5d1f479029ea6f8bea0a05fd07aa1385f6c74fde4) is working well for me.

@joefutrelle
Copy link
Contributor Author

Thanks for verifying that @srstsavage !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants