-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new build and deployment process #380
Conversation
TODO: pin dependencies and remove |
…les passed into the container
Agreed on all points, I would love a PR against |
* Attempt import of local_settings in settings.py * Remove local_settings.py from scm since its duplicated in settings.py * Allow config of postgres password from POSTGRES_PASSWORD env var * Use /dev/null for local_settings.py volume mount by default
Implemented all suggested changes in #382, let me know if anything needs to be changed! |
Great that you've also reduced the size of the image @srstsavage, any other things you want to do before I review #382? |
@joefutrelle Nope, all ready for review! |
Several suggested updates to new ifcbdb build
Note that when we merge this we should not delete the |
@srstsavage I pinned all the dependencies and created a corresponding release tag for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current state of the new_build
branch is working for me.
For the related pyifcb
library, what branch should I/we be using to test? I'm still on version_lock_scipy
, but that may be old and out of date
Nevermind; user error. I just saw your comment about the branch being named the same in that library as well. I ran the app locally using that branch and had no issues
@joefutrelle Seems to be working well! |
There's the matter of #383 which is pending against this branch, and I want to get that in before the release. @mike-kaimika do you want to retarget #383 against |
I think it probably makes more sense to get it merged into this branch, assuming neither of you had any issues with it. That way there's just one final branch for all the revisions. |
update frontend libraries
|
Deployment using the updated |
Thanks for verifying that @srstsavage ! |
docker build
.env
requiring few if any changes to docker-compose file