Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iOS group app id support & fix .d.ts #198

Merged
merged 2 commits into from
Jun 9, 2020

Conversation

Palid
Copy link
Contributor

@Palid Palid commented Jun 7, 2020

Add iOS group add id support & fix .d.ts

  • Fixes Share Extension Support #146
    This MR adds support to properly get and use group app id when provided via XCode configuration. It should automatically allow share extension or other extensions to use the library properly.
    In addition to the above, second commit also fixes types for multipart upload.

Test Plan

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS
Android

Checklist

  • I have tested this on a device and a simulator
  • [ X] I added the documentation in README.md
  • [X ] I updated the typed files (TS and Flow)
  • I've added Detox End-to-End Test(s)
  • I've created a snack to demonstrate the changes: LINK HERE

@Palid Palid force-pushed the ios-group-app-id branch 2 times, most recently from 806a02e to 55d0b18 Compare June 7, 2020 13:14
@Palid Palid force-pushed the ios-group-app-id branch from 55d0b18 to f877a13 Compare June 7, 2020 13:15
@Palid Palid changed the title Add iOS group app id support Add iOS group app id support & fix .d.ts for multipart uploads Jun 8, 2020
@Palid Palid force-pushed the ios-group-app-id branch from c13ffbb to 9f7e31a Compare June 8, 2020 10:48
@Palid Palid force-pushed the ios-group-app-id branch from 9f7e31a to 9eb55a5 Compare June 8, 2020 10:50
@Palid Palid changed the title Add iOS group app id support & fix .d.ts for multipart uploads Add iOS group app id support & fix .d.ts Jun 8, 2020
@Palid
Copy link
Contributor Author

Palid commented Jun 8, 2020

@reime005 may I have your attention please? 😄

@reime005
Copy link
Contributor

reime005 commented Jun 9, 2020

@Palid looks great, thanks!

@reime005 reime005 merged commit 6729599 into Vydia:master Jun 9, 2020
github-actions bot pushed a commit that referenced this pull request Jun 9, 2020
# [5.7.0](v5.6.1...v5.7.0) (2020-06-09)

### Features

* Add iOS group app id support & fix .d.ts ([#198](#198)) ([6729599](6729599))
@github-actions
Copy link

github-actions bot commented Jun 9, 2020

🎉 This PR is included in version 5.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

benjamin777dev added a commit to benjamin777dev/react-native-upload that referenced this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Share Extension Support
2 participants