fix: sqlalchemy version causing exception #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Christakou
approved these changes
Jan 31, 2023
asfakianakis
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The recent release of sqlalchemy 2.0.0 will not work with this version of dynamicio. Dependency was sloppily defined. Any new images created before this fix will either not work or not work if using pandas read_sql.
Key Changes
SQLAlchemy>=1.4.11toSQLAlchemy~=1.4.11Impact
Checklist
Notes
This would have been easier to debug or prevented by default if the consumer or dynamicio were using poetry.
Issue on pandas github: pandas-dev/pandas#51015