-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(inline-time-picker): support focus and focus traps (VIV-2296) #2146
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2146 +/- ##
============================================
Coverage 100.00% 100.00%
============================================
Files 123 357 +234
Lines 1562 16322 +14760
Branches 108 2925 +2817
============================================
+ Hits 1562 16322 +14760
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I commented on the changes for inline-time-picker
.
We all agreed to work in small interations. That means, each PR should have a single purpose and as few files changed as possible.
To do that, we should finish this PR for the inline-time-picker
focus handling, merge it, and then move on to using inline-time-picker
. The idea is to merge what's ready.
libs/components/src/lib/time-picker/inline-time-picker/inline-time-picker.spec.ts
Outdated
Show resolved
Hide resolved
libs/components/src/lib/time-picker/inline-time-picker/inline-time-picker.spec.ts
Outdated
Show resolved
Hide resolved
libs/components/src/lib/time-picker/inline-time-picker/inline-time-picker.template.ts
Outdated
Show resolved
Hide resolved
libs/components/src/lib/time-picker/inline-time-picker/inline-time-picker.ts
Show resolved
Hide resolved
6f2a7f9
to
0f60790
Compare
@YonatanKra Sure, I've split the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final small changes :)
libs/components/src/lib/time-picker/inline-time-picker/inline-time-picker.spec.ts
Outdated
Show resolved
Hide resolved
libs/components/src/lib/time-picker/inline-time-picker/inline-time-picker.spec.ts
Show resolved
Hide resolved
libs/components/src/lib/time-picker/inline-time-picker/inline-time-picker.spec.ts
Outdated
Show resolved
Hide resolved
…time-picker.spec.ts
No description provided.