Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(inline-time-picker): support focus and focus traps (VIV-2296) #2146

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

RichardHelm
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d61b119) to head (74cd8c7).
Report is 1310 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##              main     #2146      +/-   ##
============================================
  Coverage   100.00%   100.00%              
============================================
  Files          123       357     +234     
  Lines         1562     16322   +14760     
  Branches       108      2925    +2817     
============================================
+ Hits          1562     16322   +14760     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@YonatanKra YonatanKra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented on the changes for inline-time-picker.
We all agreed to work in small interations. That means, each PR should have a single purpose and as few files changed as possible.
To do that, we should finish this PR for the inline-time-picker focus handling, merge it, and then move on to using inline-time-picker. The idea is to merge what's ready.

@RichardHelm
Copy link
Contributor Author

@YonatanKra Sure, I've split the PR

@RichardHelm RichardHelm changed the title chore(time-picker): use inline-time-picker (VIV-2296) chore(inline-time-picker): support focus and focus traps (VIV-2296) Feb 18, 2025
Copy link
Contributor

@YonatanKra YonatanKra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final small changes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants