Feat/56 configuration for regex inputs #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
December 12, 2022 00:06
Signed-off-by: Kevin Beier <[email protected]>
Signed-off-by: Kevin Beier <[email protected]>
Signed-off-by: Kevin Beier <[email protected]>
Signed-off-by: Kevin Beier <[email protected]>
Signed-off-by: Kevin Beier <[email protected]>
Signed-off-by: Kevin Beier <[email protected]>
Signed-off-by: Kevin Beier <[email protected]>
Signed-off-by: Kevin Beier <[email protected]>
BeierKevin
added
Phase: Construction
RUP: Implementation
improvement
Claiyc
requested changes
Dec 12, 2022
There was a problem hiding this comment.
Timestamp does not work (timestamp for older log entrys gets replaced for every new one that's being added):
(notice how the time is always the same)
Also we shouldn't display anything if no value is found (check for rating = -1)
Also please do not show (?:) for emtpy regex (check for that string and replace with nothing)
|
Why should be display nothing if nothing is matched, via the rating -1 the user knows that something is wrong with the regex |
Signed-off-by: Kevin Beier <[email protected]>
We should find some other solution for that in the future imo. Agreed for now. |
added 3 commits
December 12, 2022 22:41
Signed-off-by: Kevin Beier <[email protected]>
Signed-off-by: Kevin Beier <[email protected]>
Signed-off-by: Kevin Beier <[email protected]>
Claiyc
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Describe your changes in detail here
The proper connection between backend regex (value|constraint) and the UI has been made. Additionally, in the run view when the start button is pressed a proper output what has been captured is noted down.
Definition Of Done (DoD)
This PR can be squashed / merged if
Add additional conditions here if necessary for this PR
fixes: #56