feat: next design iteration #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Beier <[email protected]>
…m/VisualGameData/VIGAD into feat/6-implement-design-iteration
Signed-off-by: Kevin Beier <[email protected]>
Signed-off-by: Kevin Beier <[email protected]>
Signed-off-by: Kevin Beier <[email protected]>
Claiyc
added
documentation
Claiyc
changed the title
added 3 commits
November 25, 2022 21:21
Signed-off-by: Kevin Beier <[email protected]>
Signed-off-by: Kevin Beier <[email protected]>
Signed-off-by: Kevin Beier <[email protected]>
BeierKevin
requested review from
FloBaumi and
roman533
and removed request for
BeierKevin
Claiyc
commented
Nov 28, 2022
roman533
previously approved these changes
Nov 28, 2022
|
Generally I'd reserve more space for the preview and less for source selection / regex definition. Maybe 70%-30% or even 80%-20% |
FloBaumi
previously approved these changes
Nov 28, 2022
Closed
Signed-off-by: Kevin Beier <[email protected]>
|
I have resolved most of the issues, maybe give quick feed back. And I would suggest that if most of the things are working i.e. capture area and the capturing in general we can make a reimplementation of the design and everything because we also need to do similar things with the capture area UI module. |
roman533
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes in detail here
This implements the next design iteration and adds basic class infrastructure and uml diagram for src/proc/
Definition Of Done (DoD)
This PR can be squashed / merged if
Add additional conditions here if necessary for this PR
fixes #14
fixes #6
fixes #17