-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: problem when deleting capture areas #198
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple solution, works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually a bigger issue than it seems… We cannot just reassign ca ids, as the VIGAD-API redis db structure relies on them (and therefore potential third party apps as well). A solution may be to have unique ids for capture areas (randomly generated). However for this solution we should provide the ability for a user to manually override the id of a capture area to keep consistency between sessions.
If there should be the option that the user can change the ID of a capture area i need to change a lot ofthings for example should the id then be only a number and what rules should this id follow if any ? |
I guess it will be easier if it is alphanumeric (so we definitely won't run into issues with collisions). However it needs to be URI conform as well. Other than that, no rules that I can think of. Maybe not too long (idk, 6 characters should be enough?) |
If this only alphanumeric isn't it always URI conform ? |
src/components/capture-area/CaptureAreaSearchValue/CaptureAreaSearchValue.vue
Outdated
Show resolved
Hide resolved
src/components/capture-area/CaptureAreaSearchValue/CaptureAreaSearchValue.vue
Outdated
Show resolved
Hide resolved
This is just a workaround, because i cant fix it really |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems to get the job done
PR description
There was a bug with the capture area array not really updating the rendered list properly because its not reactive etc. The solution may not be really good tho.
Definition Of Done (DoD)
This PR can be squashed / merged if
Add additional conditions here if necessary for this PR
fix: #186