Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upload data #185

Merged
merged 17 commits into from
Jun 1, 2023
Merged

feat: upload data #185

merged 17 commits into from
Jun 1, 2023

Conversation

roman533
Copy link
Contributor

@roman533 roman533 commented May 30, 2023

PR description

Describe your changes in detail here
data upload for data from Vigad client to server is now possible

Definition Of Done (DoD)

This PR can be squashed / merged if

  • a developer is assigned
  • the PR is NOT estimated
  • the PR is labeled
  • the PR is NOT assigned to the current sprint
  • a meaningful title has been set according to https://www.conventionalcommits.org/
  • the PR is described in detail
  • the PR links to an issue
  • the PR has been reviewed

Add additional conditions here if necessary for this PR
fix: #116

@roman533 roman533 requested a review from Claiyc May 30, 2023 12:27
@roman533 roman533 added Phase: Construction RUP: Implementation improvement Some layout / structure / performance optimization enhancement New feature or request and removed improvement Some layout / structure / performance optimization labels May 30, 2023
src/composables/useAPI/useAPI.ts Outdated Show resolved Hide resolved
src/composables/useAPI/useAPI.ts Outdated Show resolved Hide resolved
src/composables/useAPI/useAPI.ts Outdated Show resolved Hide resolved
src/proc/Vigad.ts Outdated Show resolved Hide resolved
@BeierKevin BeierKevin requested a review from Claiyc May 31, 2023 15:37
Copy link
Member

@Claiyc Claiyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Uploading data does not work with enabled session

src/proc/Vigad.ts Outdated Show resolved Hide resolved
src/proc/Vigad.ts Outdated Show resolved Hide resolved
src/proc/Vigad.ts Outdated Show resolved Hide resolved
Copy link
Member

@Claiyc Claiyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uploaded data does not represent match object. Currently only the extracted string is uploaded:
image
What we want:
{
rating: number
match: {
index: number
element: string
}
}

@BeierKevin BeierKevin requested a review from Claiyc June 1, 2023 08:16
src/proc/Vigad.ts Outdated Show resolved Hide resolved
Copy link
Member

@Claiyc Claiyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BeierKevin BeierKevin merged commit acd16d3 into main Jun 1, 2023
@BeierKevin BeierKevin deleted the feat/116-upload-data branch June 1, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload data
3 participants