-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: set default preview when stream can't be found anymore #181
Conversation
I think this implementation satisfies what the issue #71 suggests but it would be possible to rewrite the streamhandler like a composable and utilise Vue related functionalities like watching etc. to improve performance and the user experience with everything. Could be a harder issue to tackle, tho. And more like writing an composable instead of an singelton |
removed useless await Co-authored-by: Claiyc <[email protected]>
Huh I did not have these issues or at least didn't try that much out, but is this related to this implementation really or was this already before ? |
It was an issue before already |
Please resolve conflicts before next review |
Ahh ok |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
PR description
Describe your changes in detail here
If you have a program like Notepad or any other application open and selected for preview, when you close the Notepad application, the stream handler will react to it by fetching the capturable sources again and setting the main screen as the default preview. If you close Notepad and it is not the current preview, it will only trigger a refetch for the sources, ensuring that the sources tab with screens and applications is always up to date.
However, this does not happen when you open an application. I believe it is not possible with Electron to trigger a refetch automatically when opening an application. In such cases, you can simply press the refresh button, which does the job and should be sufficient.
Additionally, I added workspace settings which we should have done probably a lot earlier, which formats the code on save for everyone should be enabled per person. This was not part for this issue but noticed it and thought why not just add it.
Definition Of Done (DoD)
This PR can be squashed / merged if
Add additional conditions here if necessary for this PR
fix: #71