Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: various ts issues #145

Merged
merged 1 commit into from
May 3, 2023
Merged

fix: various ts issues #145

merged 1 commit into from
May 3, 2023

Conversation

Claiyc
Copy link
Member

@Claiyc Claiyc commented May 3, 2023 •
edited
Loading

PR description

Describe your changes in detail here
Various ts issues that needed to be fixed for #126

Definition Of Done (DoD)

This PR can be squashed / merged if

  • a developer is assigned
  • the PR is NOT estimated
  • the PR is labeled
  • the PR is NOT assigned to the current sprint
  • a meaningful title has been set according to https://www.conventionalcommits.org/
  • the PR is described in detail
    - [ ] the PR links to an issue
  • the PR has been reviewed

Add additional conditions here if necessary for this PR

@Claiyc Claiyc requested a review from BeierKevin May 3, 2023 16:55
BeierKevin
BeierKevin approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@BeierKevin BeierKevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Claiyc Claiyc merged commit 106b59c into main May 3, 2023
@Claiyc Claiyc deleted the fix/building-issues branch May 3, 2023 16:56
Claiyc added a commit that referenced this pull request May 3, 2023
@Claiyc
fix: various ts issues (#145)
6c21f55 
(cherry picked from commit 106b59c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BeierKevin BeierKevin BeierKevin approved these changes

Assignees

@Claiyc Claiyc

@2000eBe 2000eBe

Labels
bug Something isn't working Phase: Construction RUP: Implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Claiyc @BeierKevin @2000eBe