fix(components): refactored the Regex Components #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeierKevin
added
bug
BeierKevin
added
improvement
added 2 commits
April 22, 2023 23:40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Describe your changes in detail here
We had 3 components for the regex (value, before, after) definition. They shared alot of the same code. Therefore a split into one component with props etc. was neccessary and was here by done. It should work properly now but test it please so that i didn't miss anything.
Definition Of Done (DoD)
This PR can be squashed / merged if
Add additional conditions here if necessary for this PR
Fix: #97