Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(capturing): added alerts and disabled start button #120

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

BeierKevin
Copy link
Contributor

@BeierKevin BeierKevin commented Apr 21, 2023

PR description

Describe your changes in detail here

I have added an alert info on both the capturing and regex panel to notify the user that they need to first or in general have to create a capture area to start capturing. The start capturing button is disabled if no capture area exists.

Definition Of Done (DoD)

This PR can be squashed / merged if

  • a developer is assigned
  • the PR is NOT estimated
  • the PR is labeled
  • the PR is NOT assigned to the current sprint
  • a meaningful title has been set according to https://www.conventionalcommits.org/
  • the PR is described in detail
  • the PR links to an issue
  • the PR has been reviewed

Add additional conditions here if necessary for this PR

Fix: #96

@BeierKevin BeierKevin requested a review from Claiyc April 21, 2023 11:54
@BeierKevin BeierKevin self-assigned this Apr 21, 2023
@BeierKevin BeierKevin changed the title added info alert to capturing and regex panel fix(start-with-no-capturearea): added alerts and disabled start button Apr 21, 2023
@Claiyc Claiyc changed the title fix(start-with-no-capturearea): added alerts and disabled start button fix(capturing): added alerts and disabled start button Apr 21, 2023
Copy link
Member

@Claiyc Claiyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BeierKevin BeierKevin merged commit 4f6af28 into main Apr 21, 2023
@BeierKevin BeierKevin deleted the fix/96-able-to-capture-without-configuration branch April 21, 2023 20:39
@Claiyc Claiyc mentioned this pull request Apr 24, 2023
6 tasks
Claiyc added a commit that referenced this pull request May 3, 2023
added info alert to capturing and regex panel

(cherry picked from commit 4f6af28)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Start capturing without configuration
2 participants