Optimize slice last sharp tail (yarnpkg#7353)

VincentBailly · Jun 10, 2020 · 84f1d07 · 84f1d07
1 parent ea87d07
commit 84f1d07
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/cli/commands/list.js b/src/cli/commands/list.js
@@ -152,7 +152,7 @@ export async function buildTree(
 }
 
 export function getParent(key: string, treesByKey: Object): Object {
-  const parentKey = key.split('#').slice(0, -1).join('#');
+  const parentKey = key.slice(0, key.lastIndexOf('#'));
   return treesByKey[parentKey];
 }
 

diff --git a/src/hoisted-tree-builder.js b/src/hoisted-tree-builder.js
@@ -15,7 +15,7 @@ export type HoistedTree = {
 export type HoistedTrees = Array<HoistedTree>;
 
 export function getParent(key: string, treesByKey: Object): Object {
-  const parentKey = key.split('#').slice(0, -1).join('#');
+  const parentKey = key.slice(0, key.lastIndexOf('#'));
   return treesByKey[parentKey];
 }