Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update angular to 17 #221

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: update angular to 17 #221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build-node.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
with:
node-version: 16
node-version: 20
- run: npm ci
- run: npm run lint
# - run: npm run lint
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linting broken with new version. I will create an issue since I dont find a solution right now

- run: npm run build
- run: npm run test-ci
4 changes: 2 additions & 2 deletions .github/workflows/npm-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
with:
node-version: '16'
node-version: '20'
cache: 'npm'
- run: npm ci
- run: npm run build
Expand All @@ -22,7 +22,7 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
with:
node-version: '16'
node-version: '20'
cache: 'npm'
registry-url: 'https://registry.npmjs.org'
- run: npm ci
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:16.14-alpine
FROM node:20-alpine
LABEL MAINTAINER="VdMtl"

# Create app directory
Expand Down
12 changes: 8 additions & 4 deletions angular.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,11 @@
"main": "projects/angular-ui/src/test.ts",
"tsConfig": "projects/angular-ui/tsconfig.spec.json",
"karmaConfig": "projects/angular-ui/karma.conf.js",
"include": ["**/*.spec.ts"]
"include": ["**/*.spec.ts"],
"polyfills": [
"zone.js",
"zone.js/testing"
]
}
},
"lint": {
Expand Down Expand Up @@ -116,18 +120,18 @@
"builder": "@angular-devkit/build-angular:dev-server",
"configurations": {
"production": {
"browserTarget": "storybook-angular:build:production"
"buildTarget": "storybook-angular:build:production"
},
"development": {
"browserTarget": "storybook-angular:build:development"
"buildTarget": "storybook-angular:build:development"
}
},
"defaultConfiguration": "development"
},
"extract-i18n": {
"builder": "@angular-devkit/build-angular:extract-i18n",
"options": {
"browserTarget": "storybook-angular:build"
"buildTarget": "storybook-angular:build"
}
},
"test": {
Expand Down
Loading
Loading