68 multiple entries on go to definition

[Viijay-Kr]

Closes #68

@karlhorky Here is the first draft to help avoid the extra definitions results from declaration files

I m using a small typescript plugin to help this cause.

currently the option to override the definitions from declaration files can be done to settings Which is documented in the readme

Let me know what you think about this PR

[karlhorky]

Will these paths work at any level of the project?

Eg. In a monorepo / workspace project, the path would be:

<project root>/packages/package-name/node_modules/next/types/global.d.ts

Would be cool if these also worked out of the box without any additional configuration

[Viijay-Kr]

it should since the plugin does a vague/naive string comparison .

[Viijay-Kr]

@karlhorky Added a mono repo setup in the latest commit to test this out . Tested both in vite and next app inside monorepo/packages and it works as I expected.

you can also test it if you'd like
Open the monorepo folder in debug mode. Open App.tsx inside examples/monorepo/packages/vite-app/src/App.tsx and try going to the definition of styles.logo. You'll see only the css module definition is provided :)

[karlhorky]

Seems like a really cool approach!

I suggested a few changes and asked some questions

[Viijay-Kr]

Seems like a really cool approach!

I suggested a few changes and asked some questions

Thanks a lot for the comments @karlhorky . Really Appreciate your time and effort.

[karlhorky]

I tried this out just now in v1.6.2, but I'm still getting the duplicate entries:

More details:

• Page: packages/fusion.upleveled.io/app/(auth)/login/page.tsx
• CSS Module File: packages/fusion.upleveled.io/app/(auth)/login/page.module.scss
• Next.js type definitions: node_modules/next/types/global.d.ts

[karlhorky]

It seems like in the monorepo example, the packages/next-app workspace is not configured in package.json, wonder if this is related:

react-ts-css/examples/monorepo/package.json

Lines 5 to 10 in 19198f9

	"workspaces": [
	"apps/*",
	"packages/ui",
	"packages/tsconfig",
	"packages/eslint-config-custom"
	],

Eg. could that mean that the node_modules/next/types/global.d.ts is not being hoisted to the root?

[karlhorky]

If I should open a new issue, let me know.

[Viijay-Kr]

@karlhorky I too tried it after the version was shipped . It did not work for me either. I suspect it could be something to do with the typescript version difference .

I did not have time to investigate this further.

Hope I will find some time to debug this.

[karlhorky]

I'll reopen + edit the original issue so that we don't lose track of it.

[Viijay-Kr]

It seems like in the monorepo example, the packages/next-app workspace is not configured in package.json, wonder if this is related:

react-ts-css/examples/monorepo/package.json

Lines 5 to 10 in 19198f9

	"workspaces": [
	"apps/*",
	"packages/ui",
	"packages/tsconfig",
	"packages/eslint-config-custom"
	],

Eg. could that mean that the node_modules/next/types/global.d.ts is not being hoisted to the root?

This is not related .

I have removed the next app from packages in order for the package to have it own node_modules folder .

If you look at vite example it has its own node modules setup.So this helped to test the use case you mentioned

However removing the next app from the list of packages didn't make a difference since the monorepo was setup using turbo repo which provides a next boilerplate

[karlhorky]

I reopened #68 and added a comment: #68 (comment)