[WIP] Remove respond_to? check #2202
Draft
+18
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagomenegaz
force-pushed
the
remove-respond-to
branch
from
f070b12 to
14c5cf1
Compare
tiagomenegaz
force-pushed
the
remove-respond-to
branch
from
af2eadc to
691f55c
Compare
tiagomenegaz
force-pushed
the
remove-respond-to
branch
from
691f55c to
450dfd1
Compare
tiagomenegaz
force-pushed
the
remove-respond-to
branch
from
992be13 to
ffb02e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
This PR removes
respond_to?from the following files:app/controllers/concerns/view_component/preview_actions.rblib/view_component/base.rblib/view_component/collection.rblib/view_component/slotable.rblib/view_component/slotable_default.rblib/view_component/translatable.rbtest/sandbox/test/rendering_test.rbtest/sandbox/test/slotable_test.rbview_component.gemspecWhat approach did you choose and why?
Some checks aren't necessary because we don't support discontinued Ruby versions and the code can be written without
respond_to?.Anything you want to highlight for special attention from reviewers?
I noticed that some
respond_to?are being used to supportruby2_keywords. I'm assuming it exists because we want to support old ruby versions. However, based on the gemfile -ruby_version = (ENV["RUBY_VERSION"] || "~> 3.4").to_s- we don't support Ruby 2 anymore. I'll address these keywords in a different PR.