Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Renders canvas elements visible on the page #36

Closed
danpalmer opened this issue Feb 22, 2017 · 3 comments
Closed

Bug: Renders canvas elements visible on the page #36

danpalmer opened this issue Feb 22, 2017 · 3 comments
Labels

Comments

@danpalmer
Copy link

While we could solve this with the addition of some CSS, it's a little tricky to target the canvas elements created by node-vibrant as they have no class and are not contained within another element, meaning that we must have a very general CSS rule to hide them, which is not ideal.

@akfish akfish added the bug label Feb 23, 2017
@akfish
Copy link
Member

akfish commented Feb 23, 2017

Noted. Will fix in next version.

  • Hiding <canvas> element with inline style
  • (Optional) Custom <canvas> class name

akfish added a commit that referenced this issue Feb 26, 2017
@akfish
Copy link
Member

akfish commented Feb 27, 2017

Fixed in v3.0.0-alpha.1

Changes made to <canvas> element:

  • Added visibility: hidden as inline style
  • Added class name vibrant-canvas

@akfish akfish closed this as completed Feb 27, 2017
@SalGnt
Copy link

SalGnt commented Jul 30, 2018

I still face this problem, even using the latest version. The problem is that with visibility: hidden the space of the canvas is allocated on the page. My suggestion is to swap visibility: hidden with display: none.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants