Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ca-certificate package #162

Merged
merged 4 commits into from
Aug 15, 2024
Merged

Conversation

FabienYt
Copy link
Contributor

@FabienYt FabienYt commented Aug 4, 2024

Add the ca-certificate package because ldaps gives an error when verifying the certificate.

Exemple:

Caused by:
    0: Failed to connect to LDAP server
    1: native TLS error: error:16000069:STORE [...] error:0A000086:SSL routines:tls_post_process_server_certificate:certificate verify failed:../ssl/statem/statem_clnt.c:1889: (unable to get local issuer certificate)

@FabienYt
Copy link
Contributor Author

Could you merge this PR @ViViDboarder please?

@ViViDboarder
Copy link
Owner

Thanks for the reminder. Running workflows and can merge when complete.

@ViViDboarder
Copy link
Owner

Can you rebase and push again? It’s giving a lock file error, which should be resolved on main.

@FabienYt
Copy link
Contributor Author

I've just tried but it won't push anything because everything is up to date (with force too)

@ViViDboarder
Copy link
Owner

Oh! I know what it is. You bumped the version in the cargo file but not the lock file. I think if you run make build it will update the lock. Or, you can just update it manually.

@FabienYt
Copy link
Contributor Author

I just installed rust.
I run make build, everything is good now!

Updating crates.io index
Locking 1 package to latest compatible version
Updating vaultwarden_ldap v2.0.1 (vaultwarden_ldap) -> v2.0.2
[...]
Compiling vaultwarden_ldap v2.0.2 (vaultwarden_ldap)
Finished `dev` profile [unoptimized + debuginfo] target(s) in 19.16s

@FabienYt
Copy link
Contributor Author

I've just fixed the hadolint error (DL3008 warning: Pin versions in apt get install. Instead of apt-get install <package> use apt-get install <package>=<version>)

@ViViDboarder
Copy link
Owner

Thanks. That should be enough for me to ship. I’ll probably have to suppress the check for this requirement because the versions change too often.

@ViViDboarder ViViDboarder merged commit 7ae5ebb into ViViDboarder:master Aug 15, 2024
2 checks passed
@FabienYt
Copy link
Contributor Author

@ViViDboarder can you release a new version?

@ViViDboarder
Copy link
Owner

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants