Treat pom scope=runtime as compile to make gradle poms usable #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gradle's "implementation" configuration for dependencies results in published maven poms that are technically accurate for building bytecode, but useless for building J2CL. To fix this, we interpret any scope=runtime as if it says scope=compile. A separate commit will include a test case to verify that the published gwt modules in maven central work properly. Fixes Vertispan#126
niloc132
added a commit
to niloc132/j2clmavenplugin
that referenced
this pull request
Mar 3, 2022
Tests for issue Vertispan#126, PR Vertispan#130
niloc132
added a commit
to niloc132/j2clmavenplugin
that referenced
this pull request
Mar 3, 2022
Tests for issue Vertispan#126, PR Vertispan#130
xamde
pushed a commit
to Calpano/j2clmavenplugin
that referenced
this pull request
Mar 9, 2022
…pan#130) Gradle's "implementation" configuration for dependencies results in published maven poms that are technically accurate for building bytecode, but useless for building J2CL. To fix this, we interpret any scope=runtime as if it says scope=compile. A separate commit will include a test case to verify that the published gwt modules in maven central work properly. Fixes Vertispan#126
niloc132
added a commit
to niloc132/j2clmavenplugin
that referenced
this pull request
Mar 20, 2022
Tests for issue Vertispan#126, PR Vertispan#130
niloc132
added a commit
to niloc132/j2clmavenplugin
that referenced
this pull request
Mar 20, 2022
Tests for issue Vertispan#126, PR Vertispan#130
niloc132
added a commit
to niloc132/j2clmavenplugin
that referenced
this pull request
Apr 16, 2022
Tests for issue Vertispan#126, PR Vertispan#130
treblereel
pushed a commit
to treblereel/j2clmavenplugin
that referenced
this pull request
Jun 3, 2022
…pan#130) Gradle's "implementation" configuration for dependencies results in published maven poms that are technically accurate for building bytecode, but useless for building J2CL. To fix this, we interpret any scope=runtime as if it says scope=compile. A separate commit will include a test case to verify that the published gwt modules in maven central work properly. Fixes Vertispan#126
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gradle's "implementation" configuration for dependencies results in
published maven poms that are technically accurate for building
bytecode, but useless for building J2CL. To fix this, we interpret any
scope=runtime as if it says scope=compile.
A separate commit will include a test case to verify that the published
gwt modules in maven central work properly.
Fixes #126