This repository has been archived by the owner on Mar 11, 2020. It is now read-only.
Added tests to back the claims in the opened issues #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A few of the things only work once the |
|
@mgttlinger CI fails :-( |
|
@timperrett Well that's the point. I added tests which showcase these errors in the path search. |
|
@mgttlinger ok you didn't reference the issue so that wasn't clear. You're talking about #21 one assumes? We can discuss on the issue about a potential solution. Thanks for finding :-) |
timperrett
reviewed
Sep 25, 2017
| @@ -77,7 +77,7 @@ package object quiver { | |||
| * Labeled path through a graph | |||
| * @group types | |||
| */ | |||
| type LPath[N,A] = Adj[N,A] | |||
| type LPath[N,A] = (N,Vector[(N,A)]) | |||
There was a problem hiding this comment.
@kaiserpelagic can you just cast your eye over this to make sure it wont cause problems with nelson?
This was referenced Sep 25, 2017
Merged
Merged
|
Folded into release branch on #27. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.