Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Deepsource issues for #422 #424

Merged
merged 5 commits into from
Oct 31, 2023
Merged

Fix Deepsource issues for #422 #424

merged 5 commits into from
Oct 31, 2023

Conversation

ishche
Copy link
Contributor

@ishche ishche commented Oct 3, 2023

Closes #422.

@VerisimilitudeX
Copy link
Owner

Hey @ishche, thank you so much for your pull request to DNAnalyzer! I would really appreciate it if you could star this repository to show your support, if you haven't done so already. I (or another member from our team) will review your PR in the next 48 hours, and will get back to you. If you have any questions, please join our Discord server: https://discord.gg/X3YCvGf2Ug.

@VerisimilitudeX VerisimilitudeX self-requested a review October 4, 2023 23:47
@VerisimilitudeX VerisimilitudeX changed the title Fix deepsourse issues for #422 Fix Deepsource issues for #422 Oct 4, 2023
Copy link
Owner

@VerisimilitudeX VerisimilitudeX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you so much! Could you please star our repository btw. Thanks!

@gitguardian
Copy link

gitguardian bot commented Oct 31, 2023

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- Generic High Entropy Secret 1103d19 src/test/java/DNAnalyzer/core/ApiKeyServiceTest.java View secret
- Generic High Entropy Secret 6410da2 src/test/java/DNAnalyzer/core/ApiKeyServiceTest.java View secret
- Generic High Entropy Secret 6410da2 src/test/java/DNAnalyzer/core/ApiKeyServiceTest.java View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@VerisimilitudeX VerisimilitudeX merged commit b59f100 into VerisimilitudeX:main Oct 31, 2023
@ishche ishche deleted the JAVA-S1050-Non-final-static-fields branch February 4, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(JAVA-S1050) Non-final static fields should not be public
2 participants