Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CoreExecutor.createProteinList(String,String) #80

Closed
VerisimilitudeX opened this issue Sep 29, 2022 · 2 comments
Closed

Refactor CoreExecutor.createProteinList(String,String) #80

VerisimilitudeX opened this issue Sep 29, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@VerisimilitudeX
Copy link
Owner

I've selected CoreExecutor.createProteinList(String,String) for refactoring, which is a unit of 27 lines of code. Addressing this will make our codebase more maintainable and improve Better Code Hub's Write Short Units of Code guideline rating! 👍

Here's the gist of this guideline:

  • Definition 📖
    Limit the length of code units to 15 lines of code.
  • Why
    Small units are easier to analyse, test and reuse.
  • How 🔧
    When writing new units, don't let them grow above 15 lines of code. When a unit grows beyond this, split it in smaller units of no longer than 15 lines.

You can find more info about this guideline in Building Maintainable Software. 📖


ℹ️ To know how many other refactoring candidates need addressing to get a guideline compliant, select some by clicking on the 🔲 next to them. The risk profile below the candidates signals (✅) when it's enough! 🏁


Good luck and happy coding! :shipit: ✨ 💯

@VerisimilitudeX VerisimilitudeX added enhancement New feature or request hacktoberfest-accepted help wanted Extra attention is needed labels Sep 30, 2022
@iamHrithikRaj
Copy link
Contributor

Hey, I'd like to work on this. please assign this ticket to me

@VerisimilitudeX VerisimilitudeX removed the help wanted Extra attention is needed label Oct 1, 2022
@VerisimilitudeX
Copy link
Owner Author

Done.

VerisimilitudeX added a commit that referenced this issue Oct 1, 2022
…teProteinList

resolves #80: Refactor CoreExecutor.createProteinList(String,String)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants