Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Kotlin 1.3.71 #35

Merged
merged 11 commits into from
May 21, 2020
Merged

Support Kotlin 1.3.71 #35

merged 11 commits into from
May 21, 2020

Conversation

AlexeySoshin
Copy link
Contributor

This PR updates version of:

  • Kotlin 1.1.51 -> 1.3.71
  • Gradle 3.4.1 -> 6.0.1
  • Travis OpenJDK 8 -> 11
  • Jacoco 0.7~ -> 0.8.5

@AlexeySoshin
Copy link
Contributor Author

@VerachadW WDYT?

@VerachadW
Copy link
Owner

Hi @AlexeySoshin , it good for me. Just wondering if you want to bump to 1.3.72 instead?

@VerachadW VerachadW self-requested a review May 19, 2020 02:49
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2020

Codecov Report

Merging #35 into master will increase coverage by 4.98%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #35      +/-   ##
============================================
+ Coverage     83.76%   88.75%   +4.98%     
+ Complexity       68       65       -3     
============================================
  Files            16       16              
  Lines           154      160       +6     
  Branches         28       26       -2     
============================================
+ Hits            129      142      +13     
- Misses            9       10       +1     
+ Partials         16        8       -8     
Impacted Files Coverage Δ Complexity Δ
core/src/main/kotlin/me/lazmaid/kraph/Kraph.kt 96.72% <100.00%> (+11.53%) 14.00 <0.00> (+2.00)
...c/main/kotlin/me/lazmaid/kraph/lang/GraphQLNode.kt 72.00% <100.00%> (-1.08%) 16.00 <1.00> (-2.00)
.../main/kotlin/me/lazmaid/kraph/lang/SelectionSet.kt 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
...src/main/kotlin/me/lazmaid/kraph/lang/DataEntry.kt 100.00% <0.00%> (ø) 0.00% <0.00%> (-1.00%)
...rc/main/kotlin/me/lazmaid/kraph/lang/relay/Node.kt 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...in/me/lazmaid/kraph/lang/relay/CursorConnection.kt 100.00% <0.00%> (ø) 1.00% <0.00%> (ø%)
...src/main/kotlin/me/lazmaid/kraph/lang/Operation.kt 77.77% <0.00%> (+17.77%) 7.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d64d7d...7f118a5. Read the comment docs.

@AlexeySoshin
Copy link
Contributor Author

Hi @AlexeySoshin , it good for me. Just wondering if you want to bump to 1.3.72 instead?

That's a good idea.
Done!

Copy link
Owner

@VerachadW VerachadW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@VerachadW VerachadW mentioned this pull request May 20, 2020
@VerachadW
Copy link
Owner

Not sure why the travis CI status is not updated here, but since it passed. I will merge now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants