Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxy client fix for VCert Playbook and more #532

Merged
merged 6 commits into from
Sep 25, 2024
Merged

Proxy client fix for VCert Playbook and more #532

merged 6 commits into from
Sep 25, 2024

Conversation

luispresuelVenafi
Copy link
Contributor

  • Adds retry logic for waiting to get certificate in case is not ready at the certificate inventory.
  • Refactors code logic.
  • Adds missing proxy config when creating http client

@luispresuelVenafi
adds retry for certificate in case is not ready in certificate invent…
2869d57 
…ory. refactors logic. adds missing proxy config when creating http client
@luispresuelVenafi luispresuelVenafi merged commit 9077668 into master Sep 25, 2024
3 checks passed
@luispresuelVenafi luispresuelVenafi deleted the proxy-fix-and-retry branch September 25, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduardoVV EduardoVV EduardoVV approved these changes

@marcos-albornoz marcos-albornoz marcos-albornoz approved these changes

@LaloHao LaloHao LaloHao approved these changes

@rvelaVenafi rvelaVenafi Awaiting requested review from rvelaVenafi rvelaVenafi is a code owner

@JigarAtVenafi JigarAtVenafi Awaiting requested review from JigarAtVenafi

@sbanic-venafi sbanic-venafi Awaiting requested review from sbanic-venafi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luispresuelVenafi @LaloHao @marcos-albornoz @EduardoVV