Enables direct supply of a valid accessToken via the playbook for VCP… #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Improves errors on expired access token. Improves playbook validation for VCP credentials
BeardedPrincess
requested review from
rvelaVenafi,
marcos-albornoz,
luispresuelVenafi and
EduardoVV
as code owners
rvelaVenafi
reviewed
Apr 12, 2024
rvelaVenafi
approved these changes
Apr 12, 2024
EduardoVV
approved these changes
Apr 12, 2024
luispresuelVenafi
approved these changes
Apr 12, 2024
sbanic-venafi
requested changes
Apr 12, 2024
| } | ||
|
|
||
| if !apikey && !svcaccount { | ||
| return false, ErrNoCredentials | ||
| // If there's just an API key provided, that's good |
There was a problem hiding this comment.
Your logic here is a bit too complex.
I think what you're trying for here (after line 142) is:
if !svcaccount && !apikey && !accesstoken {
// none of the credential options were provided
return false, ErrNoCredentials
}
// if we got here then at least one of the credential options was provided
if (svcaccount && apikey) || (svcaccount && accesstoken) || (apikey && accesstoken) {
// more than one credential option is not acceptable
return false, ErrAmbiguousVCPCreds
}
// if we got here then only one credential option was provided (which is what we want)
return true, nil
There was a problem hiding this comment.
much better, thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…. also Improves errors on expired access token. (Previously this error was unhandled and failed at parsing an empty response body with an unexpected end of json error.
Finally, improves playbook validation for VCP credentials, and prevents more than one kind of credential to be set. Like highlander, there can now only be one! This should keep us from having to make a (wrong) prioritization decision about which credential should be used when multiple are provided.