Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve code quality #170

Closed
markos opened this issue Sep 5, 2023 · 0 comments · Fixed by #225
Closed

Improve code quality #170

markos opened this issue Sep 5, 2023 · 0 comments · Fixed by #225
Assignees
@markos
Labels
bug Something isn't working enhancement New feature or request
Milestone
5.4.12

Comments

@markos
Copy link

markos commented Sep 5, 2023 •
edited
Loading

TODO: Add static code analysis in CI #222
TODO: Remove warnings from compilations -all compilers/architectures
TODO: Enforce code formating #223
@markos markos added the enhancement New feature or request label Sep 5, 2023
@markos markos added this to the 5.4.12 milestone Sep 5, 2023
@markos markos self-assigned this Sep 5, 2023
@markos markos added the bug Something isn't working label Sep 5, 2023
@markos markos mentioned this issue Oct 10, 2023
Closed
@markos markos linked a pull request Jan 17, 2024 that will close this issue
Feature/cleanup compiler warnings #225
Merged
markos added a commit that referenced this issue Jan 20, 2024
@markos
Merge pull request #225 from VectorCamp/feature/cleanup-compiler-warn…
98eb459 
…ings

According to https://buildbot-ci.vectorcamp.gr/#/changes/93

most builds succceded and with no compiler warnings. The build failures were only on x86 and Arm for SIMDe builds: x86 because of a bug in SIMDe emulation of own x86 intrinsics in non-native mode and Arm due to clang, unsure if this is actually a bug in SIMDe or clang itself. All the remaining compiler warnings that were suppressed was because they were not possible to fix for the scope of this project. 

This PR will close #170, code quality improvements however will continue with the integration of #222 or similar static code analyzer to CI and continuous refactoring.
@markos markos mentioned this issue Jan 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markos markos

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
5.4.12
Development

Successfully merging a pull request may close this issue.

Feature/cleanup compiler warnings VectorCamp/vectorscan
1 participant
@markos