Switch to NodeSource for NodeJS packages #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the WP node modules and their dependencies are beginning to complain about our outdated versions of NodeJS and npm. NodeSource seems to be the new standard for up-to-date NodeJS packages. I've taken the conservative approach and chosen NodeJS v0.12. Note, if someone runs `apt-get update` after a `vagrant provision` without first running `vagrant destroy`, apt-get will complain about not having the appropriate key for the nodesource packages. I'm not sure what the appropriate way to handle this. It may just be adding a something to the release notes saying to run `wget -qO- https://deb.nodesource.com/gpgkey/nodesource.gpg.key | apt-key add -` if one experiences this issue.
`nodejs` is a package we install by default. Adding the NodeSource key early (if is doesn't exist), outside of the `apt_package_install_list` check, ensures that `apt-get udpate` won't complain. It also means that users won't have to run any other commands to get the latest NodeJS outside of the `apt-get` commands.
Merged
|
This and #863 is working great 👍 |
|
Updated to NodeJS 4.x LTS. I fixed locally but never pushed the change ¯_(ツ)_/¯ |
|
We're also close on this once we get a few decisions locked down in #562. |
|
I've merged the |
|
With this PR, I'm currently getting: Great stuff, thanks @thebrandonallen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the WP node modules and their dependencies are beginning to complain about our outdated versions of NodeJS and npm. NodeSource seems to be the new standard for up-to-date NodeJS packages.
I've taken the conservative approach and chosen NodeJS v0.12.
Note, if someone runs
apt-get updateafter avagrant provisionwithout first runningvagrant destroy, apt-get will complain about not having the appropriate key for the nodesource packages. I'm not sure what the appropriate way to handle this. It may just be adding a something to the release notes saying to runwget -qO- https://deb.nodesource.com/gpgkey/nodesource.gpg.key | apt-key add -if one experiences this issue.