🐛 全屏模式文末空白 #292
Closed
🐛 全屏模式文末空白 #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
是什么样子的么？可以把参数和截图发我看看不？ |
|
@Vanessa219 用 master 跑一下，height > viewport 高度时全屏模式最后就会有一大段空白。 |
|
定位到是因为 |
|
对了，我不是很清楚注释里说的 FireFox 那个问题是什么，所以还是保留了 |
|
那个是为 typewriterMode 服务的 |
|
这个 mode 的设计目的是？我在体验的时候没发现和以前有哪些不同。 |
|
好像懂了，那我的修改有点小问题 |
|
呃。我已经修复了。麻烦你了。 |
|
额，好像我说的不是你修的那个来着……我新开了一个 PR 你看看 #294 |
|
收到 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复全屏模式下文末无故空白（由
:after引起）。