Skip to content

Commit

Permalink
subprojects: Use my personal wlroots fork for with branch for now
Browse files Browse the repository at this point in the history 
We were pointing to some sha that seemed to have been GC'ed a while ago
  • Loading branch information
@misyltoad
misyltoad committed Apr 10, 2024
1 parent e30e093 commit 377365c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .gitmodules
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[submodule "subprojects/wlroots"]
path = subprojects/wlroots
url = https://gitlab.freedesktop.org/wlroots/wlroots.git
url = https://github.com/Joshua-Ashton/wlroots.git
[submodule "subprojects/libliftoff"]
path = subprojects/libliftoff
url = https://gitlab.freedesktop.org/emersion/libliftoff.git
Expand Down

3 comments on commit 377365c

@KyunLFA
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to intrude, but since I maintain a fork and the information could be of use to it, I would like to know what the reasoning is behind this practice. Personally, I find the use of git submodules+forks, instead of Meson wraps with patch files, a bit cumbersome (see my commit here as an example, I used upstream in it but feel free to use a specific sha). Other dependency bumps and wrap-ifications (most notably, Reshade) are in my fork as well if that's ever something of interest, though it's currently 5 days behind upstream and needs some housecleaning, but I'll see to it today (hopefully). Cheers and sorry again if stupid question.

@misyltoad
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Primarily because I don't want to maintain my own wrapdb of stuff and random patch files. From my perspective, git submodules are a lot easier. There is usually significant work involved to bumping a version of these libraries due to abi changes, unlike something like stb or glm or wayland-protocols.

@KyunLFA
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the thoughtful response, I'll keep it in mind. I think I still prefer wrap files for my personal use-case just because over at my fork I'll keep (trying to) follow upstream dependencies whenever possible, but it's nice to know your reasoning. Thank you for your continued work and entertaining my question. Cheers!

Please sign in to comment.