Feature/#13 erc20 timed mint #18

Marrmee · 2021-12-20T21:23:39Z

No description provided.

contracts/VALORTimedMint.sol

javier123454321 · 2021-12-20T22:03:23Z

Hey Sorry for the long list of yet to do items. The code is looking good and it makes me so happy to see you work on this. If you want to split the work and only do part we can turn any comment into their own ticket. Two main areas that I would love to see before I merge this:

Tests! We just spoke about this, and sorry for not clarifying originally.
It would be awesome to replicate the functionality of having a total cap such as the code here; https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/token/ERC20/extensions/ERC20Capped.sol I am thinking of the functionality something like this:

There should be a total max supply limit
if the max supply is hit, calling the _mint() function reverts
if the max supply is set to 0 this means there is no max supply at all and there is no upper limit to the amount of tokens.
there should probably be some checks that the initial requirement is < the cap, except if the cap is 0

javier123454321 · 2021-12-20T22:15:11Z

It would be awesome to replicate the functionality of having a total cap such as the code here; https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/token/ERC20/extensions/ERC20Capped.sol I am thinking of the functionality something like this:

There should be a total max supply limit

if the max supply is hit, calling the _mint() function reverts

if the max supply is set to 0 this means there is no max supply at all and there is no upper limit to the amount of tokens.

there should probably be some checks that the initial requirement is < the cap, except if the cap is 0

By the way, this might be good to make into another ticket, let's just focus on the other comments first.

contracts/ERC20TimedMint.sol

javier123454321 · 2021-12-22T18:13:54Z

contracts/ERC20TimedMint.sol


-    constructor(
+    uint256 public timeUntilNextMint;
+    uint256 private mintCap;


I think that we should also have a 'setter' for this function (only needs to be called internally) that way we can set to 0 if there will be no new tokens issued.

javier123454321 · 2021-12-31T05:32:08Z

contracts/ERC20TimedMint.sol

@@ -48,6 +46,14 @@ contract ERC20TimedMint is ERC20 {
        require(amount <= mintCap, "ERC20: Mint exceeds maximum amount");
        super._mint(to, amount);
    }
+
+    function _setTimeUntilNextMint(uint256 _timeDelay) external {


Just set this and _setMintCap() to internal and it will be called on the child contract.

javier123454321 · 2021-12-31T05:32:24Z

contracts/ERC20TimedMint.sol

    )   
        ERC20(name, symbol) 
    {
-        timeUntilNextMint = block.timestamp + _timeDelay;
-        mintCap = _mintCap;
+        timeUntilNextMint = block.timestamp + timeDelay;
    }

    function claimTokens (


Remove claimTokens from this contract.

javier123454321 · 2022-01-18T20:24:14Z

looks good, merging now!

Marco Huberts added 2 commits December 16, 2021 21:27

fixed compiler errors

7867eb2

Allows timed token minting

63ce5cd

javier123454321 reviewed Dec 20, 2021

View reviewed changes