Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failure labels #8

Merged
merged 1 commit into from
Jun 14, 2023
Merged

Add failure labels #8

merged 1 commit into from
Jun 14, 2023

Conversation

AMoo-Miki
Copy link

Description

Allows adding backport failure labels to the original PR.

For example, adding ...

failure_labels: "failed backport"

... to the workflow would add a "failed backport" label to a PR that had a failed backport.

Also,

  • Regenerated the lockfile
  • Refactored the utilis
  • Bumped the version

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this - it allows for discovering failures associated with the issue and then lets the repo update the pull request indicating the issue has been resolved.

Copy link
Owner

@VachaShah VachaShah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Can you also add it to the README in the features section?

@AMoo-Miki
Copy link
Author

This looks great! Can you also add it to the README in the features section?

Thanks. Features updated.

@VachaShah
Copy link
Owner

This looks great! Can you also add it to the README in the features section?

Thanks. Features updated.

Thanks @AMoo-Miki! I just pushed some changes to fix the prettier and lint errors, can you take those latest changes from main?

@VachaShah VachaShah merged commit 3a8b1f9 into VachaShah:main Jun 14, 2023
@peternied
Copy link

@VachaShah Has this change rolled out? How can we see it in https://github.com/opensearch-project/security?

@VachaShah
Copy link
Owner

@VachaShah Has this change rolled out? How can we see it in https://github.com/opensearch-project/security?

Hi @peternied it has! You can use it from version 2.2.0.

peternied added a commit to opensearch-project/security that referenced this pull request Aug 1, 2023
There have been improvements including adding a label to a pull request
when any backport on it has failed.

- Related VachaShah/backport#8

Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants