Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add relationship meta object #90

Merged
merged 4 commits into from
Jul 16, 2020
Merged

Add relationship meta object #90

merged 4 commits into from
Jul 16, 2020

Conversation

juanjduranr
Copy link
Contributor

@juanjduranr juanjduranr commented Jul 13, 2020 •
edited
Loading

Added relationship method that allows overrides to include a meta object that contains non-standard meta-information about the relationship.

@juanjduranr juanjduranr requested review from ngonzalezromero, oyanezm and ddobson and removed request for morgandenning July 15, 2020 13:45
ddobson
ddobson approved these changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@ddobson ddobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review looks good. Changes are sensible and easy to understand. 👍

@JKeller8 JKeller8 self-assigned this Jul 16, 2020
JKeller8
JKeller8 reviewed Jul 16, 2020
View reviewed changes
Copy link
Contributor

@JKeller8 JKeller8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assisting @juanjduranr with merge/tag of this PR.

@JKeller8 JKeller8 merged commit fb0e4ab into master Jul 16, 2020
@JKeller8 JKeller8 deleted the feature/add-relationship-meta-object branch July 16, 2020 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JKeller8 JKeller8 JKeller8 left review comments

@oyanezm oyanezm oyanezm approved these changes

@ddobson ddobson ddobson approved these changes

@ngonzalezromero ngonzalezromero ngonzalezromero approved these changes

Assignees

@JKeller8 JKeller8

Labels
version/minor
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@juanjduranr @oyanezm @ddobson @ngonzalezromero @JKeller8