Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchState - Fixed isRegex not set on search #994

Merged
merged 1 commit into from
Oct 26, 2016

Conversation

AlexanderArvidsson
Copy link
Contributor

Yay! We love PRs! 🎊

Please include a description of your change and ensure:

  • Commit message has a short title & issue references
  • Each commit does a logical chunk of work.
  • It builds and tests pass (e.g gulp)

More info can be found on our contribution guide.

Currently, when a SearchState object is defined, the searching begins before this.isRegex is set. This is because the setter, searchString runs the search function, and it is set in the constructor before isRegex is set, which means it will be undefined during the search.
This PR makes sure isRegex is set and available during the search by defining it before searchString.

@rebornix rebornix merged commit 8e445d6 into VSCodeVim:master Oct 26, 2016
@rebornix
Copy link
Member

thanks @Metamist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants