Implemented command mode, $, 0, ^, gg, G, plus inline search fx and Fx #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like you may have added lodash as a dev dependency. I have found that after doing an |
| ">>" : () => { vscode.commands.executeCommand("editor.action.indentLines"); }, | ||
| "<<" : () => { vscode.commands.executeCommand("editor.action.outdentLines"); }, | ||
| "dd" : () => { vscode.commands.executeCommand("editor.action.deleteLines"); }, | ||
| "dw" : () => { vscode.commands.executeCommand("deleteWordRight"); }, | ||
| "db" : () => { vscode.commands.executeCommand("deleteWordLeft"); }, | ||
| "gg" : () => { vscode.commands.executeCommand("cursorTop"); }, | ||
| "G" : () => { vscode.commands.executeCommand("cursorBottom"); }, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking over the changes I realize I might have to watch the formatting in things like the package.json. I don't understand how mine was formatted so differently. But I am also very new to git so I am not really sure how to selectively do stuff. But it was suggested to me to make this pull request so that the logic for 0 vs ^ could be in there. To keep this to a single commit, the fx and Fx are in here as well. I am hoping to chat with the major directors here though on the approach for thing like f and t commands, as you will see in my commit, I created sort of a duo key handler since it is different that two key commands. But there are a lot of ways to approach this. I have ideas, but right now this extension is so early, it might need a lot of refactoring, as we puzzle through this.