-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Angle Bracket Notation (Fixes #64) #683
Conversation
Always nice to see you again 😄 Could you actually fix this in the more general way by obliterating It would fix our longest standing bug #64 :) |
Argh, just realized this will break backwards compatibility for those that have used a I'm OK with having people needing to update their settings but open to alternatives. |
True, but we don't actually document how to do that anywhere (intentionally, since I knew this was gonna happen eventually...) Ideally we could just show an error to people who we detect have ctrl+* keybindings - say "you need to update your old keybindings to match the new format" We could even handle both in the keybindings parser. |
That should do it. Moved the angle bracket translation logic to util.ts where it is now called by:
|
|
||
1. Add the following to `settings.json` (open the Command Pallete and search for "User Settings"): | ||
|
||
``` | ||
"vim.insertModeKeyBindings": [ | ||
{ | ||
"before": ["j", "j"], | ||
"after": ["<escape>"] | ||
"after": ["<Esc>"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make this <esc>
to stay in line with Vim?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you referring to the capitalization? VimDocs have it as a capital E
so following suit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't know that! Okay, that's fine.
Easing myself back into the project after a short hiatus with this simple change.
Update: Translating key presses to Vim's angle bracket notation:
ctrl+*
becomes<C-*>
escape
becomes<Esc>
backspace
becomes<BS>
delete
becomes<Del>