-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix insert mode remaps leaving behind a character #4791
Conversation
…ue to the new historyTracker optimizations, where we don't add the new characters one by one to history, but rather just the first one and then the rest at the end.
Travis tests have failedHey @gergelyth, Node.js: 12if [[ $(git diff-index HEAD -- *.js *.ts *.md) ]]; then git diff; echo "Prettier Failed. Run `gulp forceprettier` and commit changes to resolve."; exit 1; fi
npm test
TravisBuddy Request Identifier: 21af4460-8d61-11ea-bfcd-ab7027f5d872 |
Travis tests have failedHey @gergelyth, Node.js: 12if [[ $(git diff-index HEAD -- *.js *.ts *.md) ]]; then git diff; echo "Prettier Failed. Run `gulp forceprettier` and commit changes to resolve."; exit 1; fi
npm test
TravisBuddy Request Identifier: 511d1d50-8d64-11ea-bfcd-ab7027f5d872 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tracking this one down!
Fix insert mode key remaps leaving characters behind. This happened due to the new historyTracker optimizations, where we don't add the new characters one by one to history, but rather just the first one and then the rest at the end. Fixes VSCodeVim#4787
Which issue(s) this PR fixes
Fixes #4787
Special notes for your reviewer:
Passes manual testing, however, I'm not able to run
npm test
and I'm currently not sure if that happens only on my computer or whether it is a common issue.