-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gq
range when cursor is in the middle of a line.
#4592
Conversation
Travis tests have failedHey @ldm0, Node.js: 12if [[ $(git diff-index HEAD -- *.js *.ts *.md) ]]; then git diff; echo "Prettier Failed. Run `gulp forceprettier` and commit changes to resolve."; exit 1; fi
npm test
TravisBuddy Request Identifier: 8a8df520-8803-11ea-88d0-3540a036c4cf |
src/actions/operator.ts
Outdated
// Move cursor to front of line to realign the view | ||
diff: PositionDiff.newBOLDiff(), | ||
// Move cursor to front of lowest line to realign the view | ||
diff: PositionDiff.newBOLDiff(textToReflow.split('\n').length - 1), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't work when the cursor is already at the bottom (gq5k
, for instance)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@J-Fields Ah, that's really a problem. :-/ I'll revert it.
gq
gq
range when cursor is in the middle of a line.
Travis tests have failedHey @ldm0, Node.js: 12if [[ $(git diff-index HEAD -- *.js *.ts *.md) ]]; then git diff; echo "Prettier Failed. Run `gulp forceprettier` and commit changes to resolve."; exit 1; fi
npm test
TravisBuddy Request Identifier: df87bff0-8823-11ea-88d0-3540a036c4cf |
Incorrect behaviour when cursor is in the middle of a line. Refactor: indentation should be get in paragraph reflow rather than being passed in as a parameter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Incorrect behaviour when cursor is in the middle of a line. Refactor: indentation should be get in paragraph reflow rather than being passed in as a parameter.
Bugs:
Incorrect behaviour when cursor is in the middle of a line.(fixed by expanding start and end.)
Small Refactor:
Indentation should be got in paragraph reflow rather than being passed in as a parameter.
Fixes #4590