Fixed modeHandler being recreated on every key stroke #4335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J-Fields
approved these changes
Dec 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
this.modeHandlerMap.get(editorId) returns undefined all the time, which means that a new modeHandler gets created everytime getOrCreate() gets invoked on every key press. The result was modeHandler always being in its initial state and rendering the editor completely useless.
This fix properly checks if editorId exists in the map, if it does it properly retrieves its modeHandler.
Which issue(s) this PR fixes
Fixes #4332.
Special notes for your reviewer:
I'm not sure if what was expected here was that Map.get() would call EditorIdentity.isEqual() to check editorId against the keys, but that's not what was happening.