-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify and clean up tests #4315
Conversation
Travis tests have failedHey @J-Fields, Node.js: 8if [[ $(git diff-index HEAD -- *.js *.ts *.md) ]]; then git diff; echo "Prettier Failed. Run `gulp forceprettier` and commit changes to resolve."; exit 1; fi
npm test
TravisBuddy Request Identifier: 8a7e5ee0-13fe-11ea-b320-67c429a7bc90 |
29e2e7e
to
f9f3fcb
Compare
Travis tests have failedHey @J-Fields, Node.js: 8if [[ $(git diff-index HEAD -- *.js *.ts *.md) ]]; then git diff; echo "Prettier Failed. Run `gulp forceprettier` and commit changes to resolve."; exit 1; fi
npm test
TravisBuddy Request Identifier: ece75200-140b-11ea-b320-67c429a7bc90 |
f9f3fcb
to
182cbbe
Compare
Travis tests have failedHey @J-Fields, Node.js: 8if [[ $(git diff-index HEAD -- *.js *.ts *.md) ]]; then git diff; echo "Prettier Failed. Run `gulp forceprettier` and commit changes to resolve."; exit 1; fi
npm run build
npm test
TravisBuddy Request Identifier: bd4b5570-140e-11ea-b320-67c429a7bc90 |
935fafe
to
6cf23f8
Compare
Travis tests have failedHey @J-Fields, Node.js: 8if [[ $(git diff-index HEAD -- *.js *.ts *.md) ]]; then git diff; echo "Prettier Failed. Run `gulp forceprettier` and commit changes to resolve."; exit 1; fi
npm test
TravisBuddy Request Identifier: 7fa4cb00-1410-11ea-b320-67c429a7bc90 |
6cf23f8
to
cbfaf09
Compare
Travis tests have failedHey @J-Fields, Node.js: 8if [[ $(git diff-index HEAD -- *.js *.ts *.md) ]]; then git diff; echo "Prettier Failed. Run `gulp forceprettier` and commit changes to resolve."; exit 1; fi
npm test
TravisBuddy Request Identifier: 06ac5280-1b7d-11ea-86b2-9ff47252a46a |
No functional changes here, just migrating some old tests to the `newTest` framework, enhanced that framework to check status bar, improved some test names, etc.
Someone once thought this was better than assert.equal because it checked the types, but that's not how typescript works. We now use assert.strictEqual everywhere, so let's just use it directly.
cbfaf09
to
8054c80
Compare
No description provided.