Close sidebar and bottom panel with :only command #4304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Currently :only in vscode simply reduces the number of editors (splits) to one - In vim, :only closes all open views except the one with focus (eg. it closes NERDTree, fzf and all other native/plugin windows) - The sidebar and bottom panels are already have builtin support for toggling their visibility - I believe better alignment to the vim experience is to close everything except the single pane with focus
Travis tests have failedHey @kizza, Node.js: 8if [[ $(git diff-index HEAD -- *.js *.ts *.md) ]]; then git diff; echo "Prettier Failed. Run `gulp forceprettier` and commit changes to resolve."; exit 1; finpm run buildnpm testTravisBuddy Request Identifier: caa93220-2532-11ea-a370-437b06048fa6 |
J-Fields
force-pushed
the
close-sidebar-and-panel-with-only
branch
from
3e6f220 to
5e9b134
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
:onlyin this plugin simply reduces the number of editors (splits) to one:onlycloses all open views except the one with focus (eg. it closes NERDTree, fzf and all other native/plugin windows)Current behaviour
Two splits, navigation panel and bottom panel => become identical but with a single split
Proposed behaviour
Two splits, navigation panel and bottom panel => become a single editor view
Which issue(s) this PR fixes
I couldn't find any via a search on "only"
Special notes for your reviewer: