Fix cursor off after leaving multi-cursor mode #4237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deleted code was introduced with 2cdc557. |
|
Any objections? |
|
Maybe @jpoon knows more about this code. Also, should we have a specific unit test for this case you are trying to fix? |
|
It seems this case was not covered by a test, so in order to guard against regressions, adding a test may be good idea. However I did not add new functionality but rather removed (apparently) misbehaving code. |
|
I agree - there doesn't seem to be any reason why exiting visual mode with multiple cursors would act differently than with only one. |
Previously when leaving multi-cursor mode with <Esc> the cursor would move one column to the left. For instance, when triggering multi-cursor mode on a single word, the cursor would end at the second to last character. While this is expected behavior when leaving insert mode, it is not for visual mode (which multi-cursor mode is based on). To fix, remove special case handling altogether. Fixes VSCodeVim#3775.
J-Fields
force-pushed
the
fix-cursor-off-multi
branch
from
fc348d2 to
db75197
Compare
J-Fields
approved these changes
Dec 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Previously when leaving multi-cursor mode with
<Esc>the cursor would move one column to the left. For instance, when triggering multi-cursor mode on a single word, the cursor would end at the second to last character. While this is expected behavior when leaving insert mode, it is not for visual mode (which multi-cursor mode is based on). To fix, remove special case handling altogether.Which issue(s) this PR fixes:
#3775
Special notes for your reviewer:
After giving it some thoughts, I decided to remove the special case completely. I could not reproduce any other case where conditions would match other than move-left after multi-cursor mode. To verify, I added a
console.log()in the branch in question, and ran the complete test suite. Only one test wrote a message to the console (the one I changed to expected behavior).