Fix bug causing increment/decrement issues for some number formats #4221
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When incrementing or decrementing a number, the
NumericString.parse
class is used to parse strings in to numbers of various formats. However, it used global (stateful) regexes to do this, which meant that funky things could happen after the first call to the method. This PR fixes the issue by simply removing theg
flag from some regexes.This fixes issues, for example, where pressing
<C-a>
on certain numbers more than once lead to numeric prefixes getting stripped or other odd behavior.Which issue(s) this PR fixes
Fixes #3545
Special notes for your reviewer:
@Chillee added the
g
flag in #1721. I think the rest of the logic in that PR still works correctly without theg
flags, but feel free to take a look and verify that this change is safe.