Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement <C-w> s #3563

Merged
merged 4 commits into from
Apr 14, 2019
Merged

Implement <C-w> s #3563

merged 4 commits into from
Apr 14, 2019

Conversation

aminroosta
Copy link
Contributor

Add <C-w> s to split a view horizontally.

Copy link
Contributor

@jkillian jkillian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Not a maintainer though, so you'll have to wait for one of them to come along.

I do wonder if we should switch VerticalSplit to use workbench.action.splitRight and rename OrthogonalSplit to HorizontalSplit and make it use workbench.action.splitDown. As it stands right now, the split direction of VerticalSplit can be reversed depending on your workbench.editor.openSideBySideDirection configuration which is a bit unexpected. This all is a bigger change than this PR intended though, so seems fine to leave that refactor for another time.

@jpoon
Copy link
Member

jpoon commented Mar 9, 2019

@jpoon
Copy link
Member

jpoon commented Apr 2, 2019

Ready to merge pending the doc updates.

@aminroosta
Copy link
Contributor Author

Done

@jpoon jpoon merged commit 514248c into VSCodeVim:master Apr 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants